Skip to content

Add NetSuite split exports by posting period toggle - #102605

Merged
yuwenmemon merged 3 commits into
Expensify:mainfrom
ShridharGoel:recreate-netsuite-split-exports-toggle
Oct 2, 2026
Merged

yuwenmemon merged 3 commits into
Expensify:mainfrom
ShridharGoel:recreate-netsuite-split-exports-toggle

Conversation

@ShridharGoel

@ShridharGoel ShridharGoel commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Recreates #101934 (reverted in #102588 to unblock deploy while verifying QA test steps).

Adds the "Split exports by posting period" toggle on the NetSuite export configuration page, part of cross-period expense exporting release 1. The toggle saves through UpdateNetSuiteSplitExportsByPostingPeriod. The toggles stay coupled bidirectionally: split cannot be turned on while "Export to next open period" is off (locked with subtitle), and "Export to next open period" cannot be turned off while split is on (locked with subtitle).

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/675926
PROPOSAL:

Tests

  1. Open a workspace connected to NetSuite and navigate to Settings > Workspaces > [Workspace Name] > Accounting > NetSuite > Export.
  2. Verify that "Split exports by posting period" is off by default.
  3. Turn off "Export to next open period".
  4. Verify the "Split exports by posting period" toggle below it is locked off and shows the subtitle: "Enable export to next open period to enable split non-reimbursable exports by period in NetSuite".
  5. Turn on "Export to next open period".
  6. Verify the split toggle is now enabled, the subtitle is gone, and the toggle can be turned on.
  7. Turn on "Split exports by posting period".
  8. Verify "Export to next open period" is now locked on and shows the subtitle: "To disable export to next open period, first disable split non-reimbursable exports by period.".
  9. Turn off "Split exports by posting period" and verify "Export to next open period" can be turned off again.

Vendor Bills export test:

  1. In NetSuite export settings, configure non-reimbursable expenses to export as Vendor Bills.
  2. Enable both "Export to next open period" and "Split exports by posting period".
  3. Create non-reimbursable expenses across 2–3 different calendar months on the workspace (e.g. one in August, one in September).
  4. Submit and approve the report.
  5. Export the report to NetSuite (Report > More (⋮) > Export > NetSuite).
  6. Verify in NetSuite:
    • Navigate to Transactions > Payables > Enter Bills > List (or global search bill: <reportID>).
    • Verify one Vendor Bill was created per calendar month, dated in its respective month, with external IDs suffixed with the period (e.g., VBNR_<reportID>_YYYYMM).

Expense Reports export test:

  1. In NetSuite export settings, configure non-reimbursable expenses to export as Expense Reports.
  2. Enable both "Export to next open period" and "Split exports by posting period".
  3. Create non-reimbursable expenses across 2–3 different calendar months on the workspace.
  4. Submit and approve the report.
  5. Export the report to NetSuite (Report > More (⋮) > Export > NetSuite).
  6. Verify in NetSuite:
    • Navigate to Transactions > Employees > Enter Expense Reports > List (or global search exp: <reportID>).
    • Verify one Expense Report was created per calendar month, dated in its respective month, with external IDs suffixed with the period (e.g., EXPNR_<reportID>_YYYYMM).
  • Verify that no errors appear in the JS console

Offline tests

  1. Go offline and toggle "Split exports by posting period".
  2. Verify the toggle updates immediately with a pending (greyed) state, and syncs when back online.

QA Steps

Same as tests.

To find the exported transactions in NetSuite:

  • Vendor Bills: In NetSuite, go to Transactions > Payables > Enter Bills > List or use the top search bar: bill: <reportID>.

  • Expense Reports: In NetSuite, go to Transactions > Employees > Enter Expense Reports > List or use the top search bar: exp: <reportID>.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

MacOS: Chrome / Safari
Screen.Recording.2026-09-20.at.4.42.54.PM.mov
Screen.Recording.2026-09-21.at.7.48.33.AM.mov

@melvin-bot

melvin-bot Bot commented Sep 30, 2026

Copy link
Copy Markdown

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

  1. Look at the code and make sure there are no malicious changes.
  2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx bun ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx bun ./scripts/generateTranslations.ts --compare-ref main

@ShridharGoel
ShridharGoel marked this pull request as ready for review September 30, 2026 02:33
@ShridharGoel
ShridharGoel requested review from a team as code owners September 30, 2026 02:33
@melvin-bot
melvin-bot Bot requested review from Pujan92 and flaviadefaria and removed request for a team and flaviadefaria September 30, 2026 02:33
@melvin-bot

melvin-bot Bot commented Sep 30, 2026

Copy link
Copy Markdown

@Pujan92 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@ShridharGoel

Copy link
Copy Markdown
Contributor Author

Already reviewed by @Krishna2323 here

@ShridharGoel
ShridharGoel removed the request for review from Pujan92 September 30, 2026 02:34
@Krishna2323

Copy link
Copy Markdown
Contributor

@ShridharGoel please fix the CI failures

@Krishna2323

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
android_mWeb.mp4
Android: mWeb Chrome
android_mWeb_R.mp4
iOS: HybridApp
ios_hybrid.mp4
iOS: mWeb Safari
ios_mWeb.mp4
MacOS: Chrome / Safari
web_chrome.mp4

@ShridharGoel

Copy link
Copy Markdown
Contributor Author

CI failures are on main

@codecov

codecov Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/CONST/index.ts 95.79% <ø> (ø)
src/libs/API/types.ts 100.00% <ø> (ø)
src/pages/workspace/accounting/utils.tsx 54.75% <ø> (ø)
src/libs/actions/connections/NetSuiteCommands.ts 16.06% <0.00%> (-0.27%) ⬇️
...etsuite/export/NetSuiteExportConfigurationPage.tsx 0.00% <0.00%> (ø)
... and 10 files with indirect coverage changes

@ShridharGoel
ShridharGoel requested review from yuwenmemon and removed request for Julesssss October 1, 2026 19:42
@yuwenmemon
yuwenmemon merged commit 32cf016 into Expensify:main Oct 2, 2026
36 of 38 checks passed
@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

🚧 yuwenmemon has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

OSBotify commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Oct 4, 2026
59 tasks done
@OSBotify

OSBotify commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.5.2-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site update is needed. Docs updates for E/A#101934 Add NetSuite Split exports by posting period toggle already documents this toggle and its lock behavior in Configure-Netsuite.md:79. This PR re-adds the same UI change as [Payment due Krishna2323] Add NetSuite split exports by posting period toggle.


view run

@m-natarajan

Copy link
Copy Markdown

@yuwenmemon @Julesssss @ShridharGoel
Unable to export report to Netsuite and failed to export this report to NetSuite ("Default vendor not set up for a policy. Please visit your NetSuite connected policy(ies) to ensure that a default vendor is selected.") error message displayed. Vendors section not displayed in More features of workspace settings as well. Can you please check the video attached?

bandicam.2026-10-05.16-01-17-724.mp4
Snip - (17) NetSuite  DO NOT DELETE  - More features - Google Chrome (2)

@m-natarajan

Copy link
Copy Markdown

@MelvinBot Insvetigate why failed to export this report to NetSuite ("Default vendor not set up for a policy. Please visit your NetSuite connected policy(ies) to ensure that a default vendor is selected. error message displayed for applausetester+netsuite@applause.expensifail.com account as per this thread #102605 (comment)

@MelvinBot

Copy link
Copy Markdown
Contributor

The test workspace probably has no NetSuite Default vendor selected. This PR likely isn't the cause. NetSuite needs a default vendor to create a Vendor Bill for company card expenses, and the PR's QA steps never say to pick one.

How to unblock QA:

  1. Go to Workspace > Accounting > NetSuite > Export > Export company card expenses.
  2. Make sure the destination is Vendor bill, then open Default vendor.
  3. Choose a real vendor. Don't use "None" or "-Accountant-".
  4. Export the report again.

About "Vendors" in More features: It isn't supposed to appear for NetSuite. That toggle is for vendor matching with QBO, Sage Intacct, Rillet, DualEntry, and, behind a beta, Xero and Business Central. NetSuite is left out on purpose. The NetSuite default vendor lives in the export settings above.

Suggested PR update: In the "Vendor Bills export test", add a step after step 1: "Select a Default vendor."

Investigation details
  • The error text isn't in App. The backend returns it during the export.
  • The Default vendor row only appears for company card (non-reimbursable) expenses with the Vendor bill destination: utils.ts:41-43, DynamicNetSuiteExportExpensesPage.tsx:88-99.
  • Changing the destination to Vendor bill saves only the destination. The default vendor is saved separately with UpdateNetSuiteDefaultVendor. So a workspace can be switched to Vendor bill while the vendor stays empty: NetSuiteCommands.ts:684-706.
  • More features hides the Vendors row for NetSuite: WorkspaceMoreFeaturesPage/index.tsx:167-194.
  • The PR diff doesn't touch anything vendor-related. It adds only the split toggle, its translations, and the UpdateNetSuiteSplitExportsByPostingPeriod command.

Not verified: I couldn't read the backend code or the logs. So I haven't confirmed that this workspace's default vendor is empty, or whether the split-by-period export finds the vendor differently. To rule out the PR, export the same report with Split exports by posting period turned off. If the same error appears, the cause is the workspace setup. If the export still fails after you pick a default vendor, an internal engineer needs to check the backend.


Next Steps: Reply with @MelvinBot <your feedback> to refine this analysis.


view run

@ShridharGoel

Copy link
Copy Markdown
Contributor Author

@m-natarajan Can you set the default vendor in the workspace settings?

@OSBotify

OSBotify commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/Julesssss in version: 9.5.2-4 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants